[
https://issues.apache.org/jira/browse/HDFS-11127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15655097#comment-15655097
]
Anu Engineer edited comment on HDFS-11127 at 11/10/16 8:53 PM:
---------------------------------------------------------------
[~vagarychen] Thanks for posting this patch. Some minor comments.
# I am wondering if we need {{ListVolumeResponseProto}} eventually we will
return almost all the info in {{VolumeInfoProto}}, should we just return a list
of {{VolumeInfoProto}} in list operation.
# Just something to think about, {{optional uint32 blockSize = 4;}} should we
make this required with default to 4 KB ? I don't have a strong opinion on
this, just flagging for your consideration.
# Also in {{VolumeInfoProto}} we are treating block size as {{required *uint64*
blockSize = 4;}} an unsigned 64 bit. But {{CreateVolumeRequestProto}} treats it
as uint32. Should we change {{VolumeInfoProto}} also to uint32 ?
was (Author: anu):
[~vagarychen] Thanks for posting this patch. Some minor comments.
# I am wondering if we need {{ListVolumeResponseProto}} eventually we will
return almost all the info in {{VolumeInfoProto}}, should we just return a list
of {{VolumeInfoProto}} in list operation.
# Just something to think about, {{optional uint32 blockSize = 4;}} should we
make this required with default to 4 KB ? I don't have a strong opinion on
this, just flagging for your consideration.
> Block Storage : add block storage service protocol
> --------------------------------------------------
>
> Key: HDFS-11127
> URL: https://issues.apache.org/jira/browse/HDFS-11127
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs
> Reporter: Chen Liang
> Assignee: Chen Liang
> Attachments: HDFS-11127-HDFS-7240.001.patch
>
>
> This JIRA adds block service protocol. This protocol is expose to client for
> volume operations including create, delete, info and list. Note that this
> protocol has nothing to do with actual data read/write on a particular volume.
> (Also note that the term "cblock" is the current term used to refer to the
> block storage system.)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
