[
https://issues.apache.org/jira/browse/HDFS-11127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15655203#comment-15655203
]
Anu Engineer edited comment on HDFS-11127 at 11/10/16 9:31 PM:
---------------------------------------------------------------
When do a list volume operation I would presume that we would like to see the
following information. Username, VolumeName, VolumeSize, BlockSize and ACLs. So
you can either make {{usage}} an optional field in the {{VolumeInfoProto}} thus
avoid call into SCM for listing operations or add these extra fields to
{{ListVolumeEntryProto}}. Your call on how you want it done. From code or
complexity perspective they look same to me.
bq. if this field is missing (user not specify block size), CBlock server will
use 4KB.
When you add a default option in the protoc file, you are making that explicit.
Otherwise that assumption is hidden inside the cBlock Server code. But as I
said it is not something that I feel strongly about so feel free to implement
it anyway you think is good.
was (Author: anu):
When do a list volume operation I would presume that we would like to see the
following information. Username, VolumeName, VolumeSize, BlockSize and ACLs. So
you can either make {{usage}} an optional field in the {{VolumeInfoProto}} thus
avoid call into SCM for listing operations or add these extra fields to
{{ListVolumeEntryProto}}. Your call on how you want it done. From code or
complxity perspective they look same to me.
bq. if this field is missing (user not specify block size), CBlock server will
use 4KB.
When you add a default option in the protoc file, you are making that explicit.
Otherwise that assumption is hidden inside the cBlock Server code. But as I
said it is not something that I feel strongly about so feel free to implement
it anyway you think is good.
> Block Storage : add block storage service protocol
> --------------------------------------------------
>
> Key: HDFS-11127
> URL: https://issues.apache.org/jira/browse/HDFS-11127
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs
> Reporter: Chen Liang
> Assignee: Chen Liang
> Attachments: HDFS-11127-HDFS-7240.001.patch
>
>
> This JIRA adds block service protocol. This protocol is expose to client for
> volume operations including create, delete, info and list. Note that this
> protocol has nothing to do with actual data read/write on a particular volume.
> (Also note that the term "cblock" is the current term used to refer to the
> block storage system.)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
