[
https://issues.apache.org/jira/browse/HDFS-9391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15762583#comment-15762583
]
Manoj Govindassamy edited comment on HDFS-9391 at 12/19/16 11:12 PM:
---------------------------------------------------------------------
Thanks for the quick review. Much appreciated.
bq. {{.put("inMaintenance", node.isInMaintenance())}} might not be necessary
given adminState
True. Now that {{getDeadNodes}} JSON also has adminState, both
{{decommissioned}} and {{inMaintenance}} are not needed. Have changed the usage
in {{dfshealth.js}} to check for nodes' {{adminState}} instead of
{{decommissioned}} and {{inMaintenance}} attributes.
bq. Should {{liveDecommissioningReplicas}} be {{OnlyDecommissioningReplicas}}
which is the old behavior ?
Sounds good.
* Previous to HDFS-9390 fix when MM was not there, in
{{FSNamesystem#getDecomNodes}}, for _decommissionOnlyReplicas_, we used to
return {{getDecommissionOnlyReplicas()}} which is both _decommissioning_ and
_decommissioned_ replicas.
* After HDFS-9390 fix, we started returning
{{getLeavingServiceStatus().getOutOfServiceOnlyReplicas()}} which is both
decommission and maintenance replicas. Based on our previous comments
discussions, I assume we can go back to the old behavior of returning
{{getDecommissionOnlyReplicas()}} here. I incorporated this change in patch v02.
* Now, in {{FSNameSystem#getEnteringMaintenanceNodes()}}, for
_maintenanceOnlyReplicas_, will follow the same model and return maintenance
replicas only -- {{getLeavingServiceStatus().getMaintenanceOnlyReplicas()}}.
was (Author: manojg):
Thanks for the quick review. Much appreciated.
1. bq. {{.put("inMaintenance", node.isInMaintenance())}} might not be necessary
given adminState
True. Now that {{getDeadNodes}} JSON also has adminState, both
{{decommissioned}} and {{inMaintenance}} are not needed. Have changed the usage
in {{dfshealth.js}} to check for nodes' {{adminState}} instead of
{{decommissioned}} and {{inMaintenance}} attributes.
2. bq. Should {{liveDecommissioningReplicas}} be
{{OnlyDecommissioningReplicas}} which is the old behavior ?
Sounds good.
* Previous to HDFS-9390 fix when MM was not there, in
{{FSNamesystem#getDecomNodes}}, for __decommissionOnlyReplicas__, we used to
return {{getDecommissionOnlyReplicas()}} which is both __decommissioning__ and
__decommissioned__ replicas.
* After HDFS-9390 fix, we started returning
{{getLeavingServiceStatus().getOutOfServiceOnlyReplicas()}} which is both
decommission and maintenance replicas. Based on our previous comments
discussions, I assume we can go back to the old behavior of returning
{{getDecommissionOnlyReplicas()}} here. I incorporated this change in patch v02.
* Now, in {{FSNameSystem#getEnteringMaintenanceNodes()}}, for
__maintenanceOnlyReplicas__, will follow the same model and return maintenance
replicas only -- {{getLeavingServiceStatus().getMaintenanceOnlyReplicas()}}.
> Update webUI/JMX to display maintenance state info
> --------------------------------------------------
>
> Key: HDFS-9391
> URL: https://issues.apache.org/jira/browse/HDFS-9391
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: 3.0.0-alpha1
> Reporter: Ming Ma
> Assignee: Manoj Govindassamy
> Attachments: HDFS-9391-MaintenanceMode-WebUI.pdf, HDFS-9391.01.patch,
> Maintenance webUI.png
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
