[
https://issues.apache.org/jira/browse/HDFS-11239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15765619#comment-15765619
]
Uma Maheswara Rao G commented on HDFS-11239:
--------------------------------------------
Hi [~zhouwei], Thanks for raising the issue and working on it.
Please find my feedback below.
# Implementing INode related code inside SPS class is not a good idea. All of
this implementation parts should got to name system layer. How about adding
small API which returns true if INode file is opened for write? Lets say API
name as like isINodeFileOpenedForWrite(), this can have all these lease check
and return boolean.
# -
{code}
+ running = hdfsCluster.getFileSystem()
+ .getClient().isStoragePolicySatisfierRunning();
+ Assert.assertFalse("SPS should not be able to run as file "
+ + HdfsServerConstants.MOVER_ID_PATH + " is being hold.", running);
{code}
I think it will be good if you can add test case to call satisfySatoragePolicy
as well to make sure functionality also working after SPS restart successfully
with MoverID checks
> [SPS]: Check Mover file ID lease also to determine whether Mover is running
> ---------------------------------------------------------------------------
>
> Key: HDFS-11239
> URL: https://issues.apache.org/jira/browse/HDFS-11239
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, namenode
> Reporter: Wei Zhou
> Assignee: Wei Zhou
> Attachments: HDFS-11239-HDFS-10285.00.patch
>
>
> Currently in SPS only checks the Mover ID file existence to determine whether
> a Mover is running, this can be an issue when Mover exists unexpected without
> deleting the ID file, and this further stops SPS to function. This is a
> following on to HDFS-10885 and there we bypassed this due to some
> implementation problems. This issue can be fixed after HDFS-11123.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
