[ 
https://issues.apache.org/jira/browse/HDFS-11239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15768522#comment-15768522
 ] 

Uma Maheswara Rao G commented on HDFS-11239:
--------------------------------------------

Thanks [~zhouwei] for updating the patch!
{code}
 return ((FSNamesystem)namesystem).isFileOpenedForWrite(moverId);
{code}
Please don't cast here. You can add an API to the internal interface 
Namesystem.java. 
This interface intends to communicate between namespace layer and block 
management layer. Avoid tighter code between block management and namespace 
layer.

Thanks

> [SPS]: Check Mover file ID lease also to determine whether Mover is running
> ---------------------------------------------------------------------------
>
>                 Key: HDFS-11239
>                 URL: https://issues.apache.org/jira/browse/HDFS-11239
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>            Reporter: Wei Zhou
>            Assignee: Wei Zhou
>         Attachments: HDFS-11239-HDFS-10285.00.patch, 
> HDFS-11239-HDFS-10285.01.patch
>
>
> Currently in SPS only checks the Mover ID file existence to determine whether 
> a Mover is running, this can be an issue when Mover exists unexpected without 
> deleting the ID file,  and this further stops SPS to function. This is a 
> following on to HDFS-10885 and there we bypassed this due to some 
> implementation problems.  This issue can be fixed after HDFS-11123.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to