[
https://issues.apache.org/jira/browse/HDFS-8196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857027#comment-15857027
]
Andrew Wang commented on HDFS-8196:
-----------------------------------
Nice work here [~lewuathe]! Some small review comments:
* The EC Cell Size is a property of the policy, so it'd be nice to move it down
one row, and display it like the Num Data/Parity Blocks names, i.e. {{Cell Size
(RS-DEFAULT-6-3-64k)}}. I think it'd be better to also put the units with the
value, like {{65536 bytes}}.
* Per the above, we should fetch the cell size from the default policy, not
from the constant in ECPM, and name the getter {{getDefaultPolicyCellSize}} for
consistency.
* Some sanity tests for the new MBean metrics in ECPM would be good
* Slightly odd whitespace here:
{noformat}
211 MBeans.register("NameNode",
212 "ErasureCodingPolicyManager", bean);
{noformat}
* Noticed that ECPM is abbreviated {{ecm}} in dfshealth.html and .js, would
prefer {{ecpm}} for clarity.
> Erasure Coding related information on NameNode UI
> -------------------------------------------------
>
> Key: HDFS-8196
> URL: https://issues.apache.org/jira/browse/HDFS-8196
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Affects Versions: HDFS-7285
> Reporter: Kai Sasaki
> Assignee: Kai Sasaki
> Labels: NameNode, WebUI, hdfs-ec-3.0-nice-to-have
> Attachments: HDFS-8196.01.patch, Screen Shot 2017-02-06 at
> 22.30.40.png
>
>
> NameNode WebUI shows EC related information and metrics.
> This is depend on [HDFS-7674|https://issues.apache.org/jira/browse/HDFS-7674].
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
