[
https://issues.apache.org/jira/browse/HDFS-11426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875291#comment-15875291
]
Takanobu Asanuma commented on HDFS-11426:
-----------------------------------------
Thanks for the work, [~andrew.wang]! The patch pretty looks good to me. In
addition to the whitespace issue, some very minor comments:
* It adds an unused import statement to {{AdminHelper}}.
* we can remove the import statements of {{org.apache.commons.logging}} from
{{CLITestHelper}}.
* Slightly odd new lines in {{ECAdmin.java}}:
{code}
316: };
317:
318:
319: }
{code}
> Refactor EC CLI to be similar to storage policies CLI
> -----------------------------------------------------
>
> Key: HDFS-11426
> URL: https://issues.apache.org/jira/browse/HDFS-11426
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: erasure-coding, shell
> Affects Versions: 3.0.0-alpha1
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Labels: hdfs-ec-3.0-must-do
> Attachments: HDFS-11426.001.patch, HDFS-11426.002.patch
>
>
> The {{hdfs erasurecode}} CLI is similar to {{hdfs storagepolicies}} in terms
> of functionality, but different in terms of behavior. Let's refactor
> {{ECCli}} to be more similar to the various Admin classes we already have,
> and also make its calling syntax mimic {{hdfs storagepolicies}} as closely as
> possible.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
