[ 
https://issues.apache.org/jira/browse/HDFS-11426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15876761#comment-15876761
 ] 

Wei-Chiu Chuang commented on HDFS-11426:
----------------------------------------

[~andrew.wang] I caught another issue with the patch. The unset ec policy 
command works for a directory, not a file.

{code}
  /** Command to unset the erasure coding policy set for a file/directory */
  private static class UnsetECPolicyCommand
      implements AdminHelper.Command {

    @Override
    public String getName() {
      return "-unsetPolicy";
    }

    @Override
    public String getShortUsage() {
      return "[" + getName() + " -path <path>]\n";
    }

    @Override
    public String getLongUsage() {
      TableListing listing = AdminHelper.getOptionDescriptionListing();
      listing.addRow("<path>", "The path of the file/directory "
          + "from which the erasure coding policy will be unset.");
      return getShortUsage() + "\n"
          + "Unset the erasure coding policy for a file/directory.\n\n"
          + listing.toString();
    }
{code}

> Refactor EC CLI to be similar to storage policies CLI
> -----------------------------------------------------
>
>                 Key: HDFS-11426
>                 URL: https://issues.apache.org/jira/browse/HDFS-11426
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: erasure-coding, shell
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>              Labels: hdfs-ec-3.0-must-do
>         Attachments: HDFS-11426.001.patch, HDFS-11426.002.patch
>
>
> The {{hdfs erasurecode}} CLI is similar to {{hdfs storagepolicies}} in terms 
> of functionality, but different in terms of behavior. Let's refactor 
> {{ECCli}} to be more similar to the various Admin classes we already have, 
> and also make its calling syntax mimic {{hdfs storagepolicies}} as closely as 
> possible.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to