[ 
https://issues.apache.org/jira/browse/HDFS-11426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880993#comment-15880993
 ] 

Andrew Wang commented on HDFS-11426:
------------------------------------

Hi [~surendrasingh] so your review comment actually relates to HDFS-11428 which 
I already have a patch up for. {{setECPolicy}} requires an ECPolicy object, 
which we can't get without calling {{getECPolicies}} first. HDFS-11428 changes 
it to take a string like {{setStoragePolicy}} which avoids this extra RPC.

I plan to commit this by EOD based on Wei-chiu's +1, hoping that we can address 
further issues in follow-on JIRAs. 

> Refactor EC CLI to be similar to storage policies CLI
> -----------------------------------------------------
>
>                 Key: HDFS-11426
>                 URL: https://issues.apache.org/jira/browse/HDFS-11426
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: erasure-coding, shell
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>              Labels: hdfs-ec-3.0-must-do
>         Attachments: HDFS-11426.001.patch, HDFS-11426.002.patch, 
> HDFS-11426.003.patch
>
>
> The {{hdfs erasurecode}} CLI is similar to {{hdfs storagepolicies}} in terms 
> of functionality, but different in terms of behavior. Let's refactor 
> {{ECCli}} to be more similar to the various Admin classes we already have, 
> and also make its calling syntax mimic {{hdfs storagepolicies}} as closely as 
> possible.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to