[ 
https://issues.apache.org/jira/browse/HDFS-11511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15906358#comment-15906358
 ] 

Arpit Agarwal commented on HDFS-11511:
--------------------------------------

Thanks for this improvement [~hanishakoneru]. The patch looks great. Two minor 
comments:
# The TimeoutFuture and AbstractFuture classes must carry notices that they 
were modified. See clause 4.b. of the Apache License. 
http://www.apache.org/licenses/LICENSE-2.0
# Don't allocate scheduledThreadPoolExecutor when diskCheckTimeout == 0.

I am still reviewing the unit test.



> Support Timeout when checking single disk
> -----------------------------------------
>
>                 Key: HDFS-11511
>                 URL: https://issues.apache.org/jira/browse/HDFS-11511
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs
>            Reporter: Hanisha Koneru
>            Assignee: Hanisha Koneru
>         Attachments: HDFS-11511.000.patch, HDFS-11511.001.patch
>
>
> HDFS-11149 introduces parallel checking of FsVolumes by Datanode. Disk checks 
> should have a configurable timeout so that bad disks do not hang and cause 
> long running checks.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to