[ 
https://issues.apache.org/jira/browse/HDFS-11511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15927268#comment-15927268
 ] 

Arpit Agarwal commented on HDFS-11511:
--------------------------------------

- The javac and javadoc warnings are in the imported code.
- asflicense issues are unrelated to this patch.
- The test failures are unrelated, verified them locally.

I will commit the v004 patch shortly. Here is the delta from the v003 patch.
{code}
diff --git 
a/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml 
b/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
index 6064be12476..be54efb2422 100644
--- a/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
+++ b/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
@@ -242,17 +242,14 @@
     </Match>
     <Match>
         <Class 
name="org.apache.hadoop.hdfs.server.datanode.checker.AbstractFuture" />
-        <Method name="AbstractFuture" />
         <Bug pattern="DLS_DEAD_STORE_OF_CLASS_LITERAL" />
     </Match>
     <Match>
         <Class 
name="org.apache.hadoop.hdfs.server.datanode.checker.AbstractFuture" />
-        <Method name="setFuture" />
         <Bug pattern="DLS_DEAD_LOCAL_STORE" />
     </Match>
     <Match>
         <Class 
name="org.apache.hadoop.hdfs.server.datanode.checker.AbstractFuture" />
-        <Method name="cancel" />
         <Bug pattern="NS_DANGEROUS_NON_SHORT_CIRCUIT" />
     </Match>
  </FindBugsFilter>
{code}

> Support Timeout when checking single disk
> -----------------------------------------
>
>                 Key: HDFS-11511
>                 URL: https://issues.apache.org/jira/browse/HDFS-11511
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs
>            Reporter: Hanisha Koneru
>            Assignee: Hanisha Koneru
>         Attachments: HDFS-11511.000.patch, HDFS-11511.001.patch, 
> HDFS-11511.002.patch, HDFS-11511.003.patch, HDFS-11511.004.patch
>
>
> HDFS-11149 introduces parallel checking of FsVolumes by Datanode. Disk checks 
> should have a configurable timeout so that bad disks do not hang and cause 
> long running checks.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to