[ 
https://issues.apache.org/jira/browse/HDFS-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032186#comment-13032186
 ] 

Todd Lipcon commented on HDFS-1505:
-----------------------------------

+    if (storage.getNumStorageDirs(NameNodeDirType.IMAGE) == 0 &&
+        storage.getNumStorageDirs(NameNodeDirType.EDITS) == 0 &&
+        storage.getNumStorageDirs(NameNodeDirType.IMAGE_AND_EDITS) == 0) {
+      throw new IOException("Failed to save any storage directories while 
saving namespace");

I think the check for .EDITS is incorrect -- if we lose all the IMAGE and 
IMAGE_AND_EDITS dirs, but still have EDITS dirs, we're still screwed.

> saveNamespace appears to succeed even if all directories fail to save
> ---------------------------------------------------------------------
>
>                 Key: HDFS-1505
>                 URL: https://issues.apache.org/jira/browse/HDFS-1505
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 0.22.0, 0.23.0
>            Reporter: Todd Lipcon
>            Assignee: Jakob Homan
>            Priority: Blocker
>             Fix For: 0.22.0
>
>         Attachments: hdfs-1505-22.0.patch, hdfs-1505-test.txt, 
> hdfs-1505-trunk.0.patch
>
>
> After HDFS-1071, saveNamespace now appears to "succeed" even if all of the 
> individual directories failed to save.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to