[
https://issues.apache.org/jira/browse/HDFS-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032697#comment-13032697
]
Aaron T. Myers commented on HDFS-1505:
--------------------------------------
bq. That is, isOfType() is permissive rather than exclusive.
You are quite correct. My mistake. The original logic you posted for the check
seems to be correct.
bq. Also, since HDFS-1826 copied the concurrent saveNamespace() logic into
FSImage.doUpgrade(), would you please add the same code fragment to the end of
doUpgrade(), and a corresponding corruption unit test case to TestDFSUpgrade?
Thanks.
It occurs to me now that the failure handling should perhaps be different
between these two cases. i.e. it is acceptable to tolerate some number of
storage directory failures during save namespace, but we should perhaps throw
an error in the event *any* storage directories fail during upgrade. Thoughts?
> saveNamespace appears to succeed even if all directories fail to save
> ---------------------------------------------------------------------
>
> Key: HDFS-1505
> URL: https://issues.apache.org/jira/browse/HDFS-1505
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.22.0, 0.23.0
> Reporter: Todd Lipcon
> Assignee: Aaron T. Myers
> Priority: Blocker
> Fix For: 0.22.0
>
> Attachments: hdfs-1505-22.0.patch, hdfs-1505-22.1.patch,
> hdfs-1505-test.txt, hdfs-1505-trunk.0.patch, hdfs-1505-trunk.1.patch
>
>
> After HDFS-1071, saveNamespace now appears to "succeed" even if all of the
> individual directories failed to save.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
