[
https://issues.apache.org/jira/browse/HDFS-11531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15944272#comment-15944272
]
Colin P. McCabe commented on HDFS-11531:
----------------------------------------
bq. It looks like Hadoop QA does not track native tests.
Yeah, this has been a problem for a while Hopefully it at least runs them now
(the cmake plugin helped with that).
{code}
+ if (m) free(m);
{code}
You don't need this because {{free}} checks if the pointer is {{NULL}}.
{code}
+ LIBHDFS_EXTERNAL
+ int hdfsGetHedgedReadMetrics(hdfsFS fs, struct hdfsHedgedReadMetrics
**metrics);
{code}
Why not just return the {{hdfsHedgedReadMetrics}} pointer? The error is in
{{errno}} anyway on a failure.
Looks good aside from that.
> Expose hedged read metrics via libHDFS API
> ------------------------------------------
>
> Key: HDFS-11531
> URL: https://issues.apache.org/jira/browse/HDFS-11531
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: libhdfs
> Affects Versions: 2.6.0
> Reporter: Sailesh Mukil
> Assignee: Sailesh Mukil
> Attachments: HDFS-11531.000.patch, HDFS-11531.001.patch
>
>
> It would be good to expose the DFSHedgedReadMetrics via a libHDFS API for
> applications to retrieve.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
