[ 
https://issues.apache.org/jira/browse/HDFS-11531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945827#comment-15945827
 ] 

Sailesh Mukil commented on HDFS-11531:
--------------------------------------

Thanks for the comments [~cmccabe], I will address them after clarifying the 
below.

> Why not just return the hdfsHedgedReadMetrics pointer? The error is in errno 
> anyway on a failure.

I agree. However, I was following the same API style exposed by 
hdfsFileGetReadStatistics() and hdfsFileFreeReadStatistics():
https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfs/hdfs.c#L96

If you still think I should change it to return the struct, I can go ahead and 
do so.

> Expose hedged read metrics via libHDFS API
> ------------------------------------------
>
>                 Key: HDFS-11531
>                 URL: https://issues.apache.org/jira/browse/HDFS-11531
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: libhdfs
>    Affects Versions: 2.6.0
>            Reporter: Sailesh Mukil
>            Assignee: Sailesh Mukil
>         Attachments: HDFS-11531.000.patch, HDFS-11531.001.patch
>
>
> It would be good to expose the DFSHedgedReadMetrics via a libHDFS API for 
> applications to retrieve.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to