[ 
https://issues.apache.org/jira/browse/HDFS-11470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15950224#comment-15950224
 ] 

Weiwei Yang commented on HDFS-11470:
------------------------------------

Hi [~anu]

Thanks for creating this, looks really good. I have some questions and comments 
below,

# Permission. Who can run these commands, most of them seem to require admin 
privilege, e.g create/delete container, pipeline, node pools; some other 
commands might be applicable for normal users, info container, pipeline, node 
pools. Usually commands under {{-admin}} requires admin permission and others 
don't, is it same for SCM commands?
# Command output. What is the output of each command, json format data?
# Put key allows an argument {{-o}} to write a file into a container with they 
key, does this only support local file? Does it make sense to support DFS 
compatible files? Same as other {{-o}} options for other commands, 
getContainer, getKey etc.
# List key seems required, otherwise how an user would know key names they can 
possibly operate on? I implemented listKey API in HDFS-11569, we can have 
similar API open for commandline, that way user can specify prefix, preKey name 
and count to get a better looking result. This seamlessly can support list key 
range by range if user wants.
# Create container. Container ID is more an internal thing, would it make sense 
to let SCM return a container ID for user? Split this command to 2 phase call, 
first {{hdfs scm -container create -p <pipelineID>}}, it returns a container ID 
in the output, then {{hdfs scm -container create <containerID> -p 
<pipelineID>}} to actually create it. If this is just for dev purpose, might 
not be necessary.
# List container. Would it be useful to support {{-end}} option as well?
# Remove a node from pool. What happens at the backend, is it similar to 
decommission this node? Do we move the containers on this node to another node 
in the same pool? 
# This might not be relevant, but still want to ask. Will it be necessary to 
support balance pool? That says to move containers across nodes in a same pool 
to get a better balanced disk usage.

Thanks

> Ozone: SCM: Add SCM CLI
> -----------------------
>
>                 Key: HDFS-11470
>                 URL: https://issues.apache.org/jira/browse/HDFS-11470
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Xiaoyu Yao
>            Assignee: Xiaoyu Yao
>         Attachments: storage-container-manager-cli-v001.pdf
>
>
> This jira the describes the SCM CLI. Since CLI will have lots of commands, we 
> will file other JIRAs for specific commands.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to