[
https://issues.apache.org/jira/browse/HDFS-11675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15987798#comment-15987798
]
Anu Engineer commented on HDFS-11675:
-------------------------------------
[~cheersyang] Thanks for the patch.
Two minor nits:
* {{ContainerOperationClient.java#deleteContainer}}
LOG.info ==> LOG.debug -- Since the call worked as expected ?
* The following comment seems to be wrong.
{code}
/**
* Deletes a container in SCM.
*/
rpc getContainer
{code}
* Just to make sure that my understanding is correct, when I delete a
container -- we get the location of where the container is living
from the SCM and go to the data node and use container protocol to delete the
container.
-- If that is true, wouldn't the container name exist in the SCM ?
We might have to delete the container name from SCM also.
-- A simple test to make sure that we delete container correctly, would be
to create-delete-create the same container.
-- I am little conflicted about the force parameter, on one hand
it is extremely useful for developers. But the only true use case of
force parameter is to remove a container when we are in a
over replicated state.
-- So before deleting a container we have to delete all the
keys, otherwise SCM will return this container as a location of the keys
or disable the use of force.
> Ozone: SCM CLI: Implement delete container command
> --------------------------------------------------
>
> Key: HDFS-11675
> URL: https://issues.apache.org/jira/browse/HDFS-11675
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Reporter: Weiwei Yang
> Assignee: Weiwei Yang
> Labels: command-line
> Attachments: HDFS-11675-HDFS-7240.001.patch,
> HDFS-11675-HDFS-7240.002.patch
>
>
> Implement delete container
> {code}
> hdfs scm -container del <container name> -f
> {code}
> Deletes a container if it is empty. The -f options can be used to force a
> delete of a non-empty container. If container name specified not exist,
> prints a clear error message.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
