[
https://issues.apache.org/jira/browse/HDFS-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000591#comment-16000591
]
Yiqun Lin commented on HDFS-11763:
----------------------------------
Thanks [~msingh] for the review!
The comment makes sense to me. But I am thinking current logic has already
addressed your point. Please see the following codes:
Fox example in {{Dispatcher#containerProcessHandler}}:
{code}
private ContainerCommandResponseProto containerProcessHandler(
ContainerCommandRequestProto msg) throws StorageContainerException {
try {
...
} catch (StorageContainerException e) {
return ContainerUtils.logAndReturnError(LOG, e, msg); <==
StorageContainerException will be caught here and then used to construct the
response
} catch (IOException ex) {
...
}
{code}
The error code that we set in the patch will be okay since we are sure the
IOException here is not the type of {{StorageContainerException}}.
> Ozone: Add finer error codes for container operaions
> ----------------------------------------------------
>
> Key: HDFS-11763
> URL: https://issues.apache.org/jira/browse/HDFS-11763
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Yiqun Lin
> Assignee: Yiqun Lin
> Priority: Minor
> Attachments: HDFS-11763-HDFS-7240.001.patch
>
>
> Ii would be better to add more finer error codes for operation relevant
> operations as this suggested in the codes. It will benefit for us to find and
> describe the exception cause. Currently all the container operation error was
> using the same result code {{CONTAINER_INTERNAL_ERROR}}. This seems too
> coarse-grained.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
