[
https://issues.apache.org/jira/browse/HDFS-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000842#comment-16000842
]
Anu Engineer commented on HDFS-11763:
-------------------------------------
[~linyiqun] Thanks for the patch. [~msingh] Thanks for the review comments.
[~linyiqun] We are making a particular call and we get a reply for that. I am
trying to understand what additional information I get from these error codes.
This is what I understand from the code patch, please correct me if I am wrong.
Right now:
# If we make a call -- say createContainer -- it is possible that we will get
CONTAINER_INTERNAL_ERROR, in the new scheme -- we will get
CREATE_CONTAINER_ERROR instead of CONTAINER_INTERNAL_ERROR.
I am trying to understand how it is more useful, Do you think createContainer +
CREATE_CONTAINER_ERROR has more information than earlier error code.
As mukul mentioned, we return specific error code from actual errors, if we run
into an error that we are not able to map to any specific issue, then we return
this error. So in the long run CONTAINER_INTERNAL_ERROR should be very rare.
So these finer error codes will fall into that category -- as we return better
and better error code from the containers -- the internal errors or these
generic errors will be used less and less. In a perfect world, we should never
be returning these catch all error codes.
So I am kind of ambivalent about this change , I know it is a harm less change
but in the long run we will remove or use very less of this change.
if I have missed a specific use case, would you please point me to it ? If you
seeing a specific case where you are getting an internal error, that might be a
chance for us to go fix the root issue and return the correct error code.
> Ozone: Add finer error codes for container operaions
> ----------------------------------------------------
>
> Key: HDFS-11763
> URL: https://issues.apache.org/jira/browse/HDFS-11763
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Yiqun Lin
> Assignee: Yiqun Lin
> Priority: Minor
> Attachments: HDFS-11763-HDFS-7240.001.patch
>
>
> Ii would be better to add more finer error codes for operation relevant
> operations as this suggested in the codes. It will benefit for us to find and
> describe the exception cause. Currently all the container operation error was
> using the same result code {{CONTAINER_INTERNAL_ERROR}}. This seems too
> coarse-grained.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
