[
https://issues.apache.org/jira/browse/HDFS-11775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015774#comment-16015774
]
Nandakumar commented on HDFS-11775:
-----------------------------------
Thanks for the review [~vagarychen].
bq. seems TestBucketManagerImpl#testCreateBucket only makes sure there is no
exception. Can we also check if the bucket is correctly created?
For now checking the existence of created bucket in DB using mocked
MetadataManager is added, and TODO: Use BucketManagerImpl#getBucketInfo to
verify creation of bucket.
bq.how about adding some wrappers to MetadataManager
Modified MetadataManager to have following methods
* void start();
* void stop() throws IOException;
* Lock readLock();
* Lock writeLock();
* byte[] get(byte[] key);
* void put(byte[] key, byte[] value);
* void batchPut(List<Map.Entry<byte[], byte[]>> list) throws IOException;
Please find the changes in patch 007.
> Ozone: KSM : add createBucket
> ------------------------------
>
> Key: HDFS-11775
> URL: https://issues.apache.org/jira/browse/HDFS-11775
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Anu Engineer
> Assignee: Nandakumar
> Attachments: HDFS-11775-HDFS-7240.000.patch,
> HDFS-11775-HDFS-7240.001.patch, HDFS-11775-HDFS-7240.002.patch,
> HDFS-11775-HDFS-7240.003.patch, HDFS-11775-HDFS-7240.004.patch,
> HDFS-11775-HDFS-7240.005.patch, HDFS-11775-HDFS-7240.006.patch,
> HDFS-11775-HDFS-7240.007.patch
>
>
> Creates a bucket if it does not exist. A precondition to creating a bucket is
> that a parent volume must exist.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
