[ 
https://issues.apache.org/jira/browse/HDFS-11779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025138#comment-16025138
 ] 

Weiwei Yang commented on HDFS-11779:
------------------------------------

Hi [~nandakumar131]

Thanks for reviewing this. I agree with your all 3 comments, I'll address #1 
and #2 in next patch, about #3, I listed as a TODO item and I plan to do that 
in another patch. See {{DistributedStorageHandler#listBuckets}}

{noformat}
    // Get bucket list from KSM. Note it is possible the client
    // only provides the volume name. KSM will return all buckets
    // belong to this user in this volume in a huge list.
    // TODO add a safe check in case bucket list overflows, e.g >100.
{noformat}

but yeah, it probably worth to add a check for the utility method 
{{LevelDBStore#getRangeKVs}}  as well, but it would be tricky how to define the 
limit... anyway, I will open another JIRA to track this.

Thank you.

> Ozone: KSM: add listBuckets
> ---------------------------
>
>                 Key: HDFS-11779
>                 URL: https://issues.apache.org/jira/browse/HDFS-11779
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Anu Engineer
>            Assignee: Weiwei Yang
>         Attachments: HDFS-11779-HDFS-7240.001.patch
>
>
> Lists buckets of a given volume. Similar to listVolumes, paging supported via 
> prevKey, prefix and maxKeys.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to