[ 
https://issues.apache.org/jira/browse/HDFS-11779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025774#comment-16025774
 ] 

Weiwei Yang commented on HDFS-11779:
------------------------------------

Hi [~linyiqun]

Thank you for reviewing the patch, looking forward for more comments if you 
have. Thanks.

bq. Can you use numBuckets to replace the parameter count?

Fixed.

bq. It seems we don't need to print test directory here, right?

Correct, removed that line.

bq. Can you add more detailed error info when we found the volume bucket is 
null.

I don't think this is an error here. The KSM database stores not only bucket 
key (with schema /volume_name/bucket_name), it also stores volume key (with 
schema /volume_name) and user key (with schema $user_name). It is expected that 
some of the keys will not match the pattern here so null value is expected 
instead of an error. Please let me know if this makes sense to you.

Thank you.

> Ozone: KSM: add listBuckets
> ---------------------------
>
>                 Key: HDFS-11779
>                 URL: https://issues.apache.org/jira/browse/HDFS-11779
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Anu Engineer
>            Assignee: Weiwei Yang
>         Attachments: HDFS-11779-HDFS-7240.001.patch, 
> HDFS-11779-HDFS-7240.002.patch, HDFS-11779-HDFS-7240.003.patch
>
>
> Lists buckets of a given volume. Similar to listVolumes, paging supported via 
> prevKey, prefix and maxKeys.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to