[
https://issues.apache.org/jira/browse/HDFS-11771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029958#comment-16029958
]
Anu Engineer commented on HDFS-11771:
-------------------------------------
[~msingh] Thanks for updating the patch. some very minor comments. Otherwise I
think we are good to go.
* KSMPbHelper.java:convertOzoneAcl
{code}
String userName;
if (acl.getName() == null) {
if (acl.getType() != OzoneAcl.OzoneACLType.WORLD) {
throw new IllegalArgumentException("Only root can have null username");
}
userName = "root";
} else {
userName = acl.getName();
}
{code}
I am not sure why we permit the null user at all ?
* nit: KsmVolumeArgs.java:ctor
Add new parameter to the arguments doc.
* OzoneMetadataManager.java:
The reason why we use ErrorTable.newError is to make sure that all web based
error message have a consitent format. If we need to add a newError that takes
a parameter, please feel free to add that to ErrorTable. This way REST API
error messages are consistent.
* VolumeArgs.java:
{{@param groups - list of groups user is part of}}
This comment seems wrong. It is the list of groups that is allowed to access
this volume.
> Ozone: KSM: Add checkVolumeAccess
> ----------------------------------
>
> Key: HDFS-11771
> URL: https://issues.apache.org/jira/browse/HDFS-11771
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Anu Engineer
> Assignee: Mukul Kumar Singh
> Attachments: HDFS-11771-HDFS-7240.001.patch,
> HDFS-11771-HDFS-7240.002.patch, HDFS-11771-HDFS-7240.003.patch
>
>
> Checks if the caller has access to a given volume. This call supports the
> ACLs specified in the ozone rest protocol documentation.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
