[
https://issues.apache.org/jira/browse/HDFS-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035936#comment-13035936
]
Todd Lipcon commented on HDFS-1568:
-----------------------------------
Hey Joey,
It looks like a lot of the changes in this patch are just reformatting code
without changing the underlying message. eg:
- LOG.warn("Block token verification failed: op=" + op
- + ", remoteAddress=" + remoteAddress
- + ", message=" + e.getLocalizedMessage());
+ LOG.warn("Block token verification failed: op=" + op +
+ ", remoteAddress=" + remoteAddress +
+ ", message=" + e.getLocalizedMessage());
would it be possible to format a patch which just contains changes which
actually change output? That would be easier to review.
> Improve DataXceiver error logging
> ---------------------------------
>
> Key: HDFS-1568
> URL: https://issues.apache.org/jira/browse/HDFS-1568
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Joey Echeverria
> Priority: Minor
> Labels: newbie
> Attachments: HDFS-1568-1.patch
>
>
> In supporting customers we often see things like SocketTimeoutExceptions or
> EOFExceptions coming from DataXceiver, but the logging isn't very good. For
> example, if we get an IOE while setting up a connection to the downstream
> mirror in writeBlock, the IP of the downstream mirror isn't logged on the DN
> side.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
