[ 
https://issues.apache.org/jira/browse/HDFS-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036954#comment-13036954
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-1568:
----------------------------------------------

Thanks Joey.

- It is better to log before {{ERROR.write(out)}}, otherwise, 
{{ERROR.write(out)}} may throw another exception.
{code}
       } catch(IOException e) {
         ERROR.write(out);
+        LOG.info("opReadBlock " + block + " received exception " + e);
         throw e;
       }
{code}

- Since the exception e is re-thrown, are you sure that it won't be printed 
twice?
{code}
           if (isClient) {
+            LOG.error(datanode + ":Exception transfering block " +
+                     block + " to mirror " + mirrorNode +
+                     ".", e);
             throw e;
{code}


> Improve DataXceiver error logging
> ---------------------------------
>
>                 Key: HDFS-1568
>                 URL: https://issues.apache.org/jira/browse/HDFS-1568
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>    Affects Versions: 0.23.0
>            Reporter: Todd Lipcon
>            Assignee: Joey Echeverria
>            Priority: Minor
>              Labels: newbie
>         Attachments: HDFS-1568-1.patch, HDFS-1568-3.patch, 
> HDFS-1568-output-changes.patch
>
>
> In supporting customers we often see things like SocketTimeoutExceptions or 
> EOFExceptions coming from DataXceiver, but the logging isn't very good. For 
> example, if we get an IOE while setting up a connection to the downstream 
> mirror in writeBlock, the IP of the downstream mirror isn't logged on the DN 
> side.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to