[
https://issues.apache.org/jira/browse/HDFS-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Todd Lipcon updated HDFS-1893:
------------------------------
Attachment: hdfs-1893.txt
OK, I think this is ready for a full review.
I went through and did another pass of cleanup/self review. Among the changes:
- added INVALID_TXID as a constant (-12345 to distinguish it from off-by-one
errors which might have caused -1)
- added TODO_TXID in BackupNode instead of using 0xDEADBEEF
- Fixed up TestCheckpoint which had some DEADBEEF placeholders as well.
- various bits of javadocs/comments/log cleanup
Ivan: I see your point regarding finalizing log segments. I'd like to address
that in a follow-up if that's OK.
BTW, one nice stat: this patch actually removes more code than it adds in
src/java. That's great feedback that this is indeed less complex than what we
did before!
> Change edit logs and images to be named based on txid
> -----------------------------------------------------
>
> Key: HDFS-1893
> URL: https://issues.apache.org/jira/browse/HDFS-1893
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Affects Versions: Edit log branch (HDFS-1073)
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: Edit log branch (HDFS-1073)
>
> Attachments: hdfs-1893-prelim.txt, hdfs-1893.txt, hdfs-1893.txt,
> hdfs-1893.txt
>
>
> This is the main subtask of HDFS-1073: actually switch over the naming of the
> files to the new format as described in the design doc.
> I imagine it will be split out into a couple separate JIRAs before being
> committed, but this still be the "big kahuna" patch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
