[ 
https://issues.apache.org/jira/browse/HDFS-1969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036957#comment-13036957
 ] 

Konstantin Shvachko commented on HDFS-1969:
-------------------------------------------

Good catch Todd. I definitely tested it back in old times. Too bad the tests 
were wrong.
Couple nits on the patch

# We should print what is the current version of the NN in the message
{code}
- " using this version of the NameNode. Please use the previous" +
+ " using NameNode version " + FSConstants.LAYOUT_VERSION + ". Please use " + 
prevState.getLayoutVersion() +
{code}
# Do you need to import {{IncorrectVersionException}}?
# Also in {{NNStorage}} I don't think we should allow writing older image 
version by the newer software. The NN should fail before that. And NN should be 
able to write ONLY current version image.

> Running rollback on new-version namenode destroys namespace
> -----------------------------------------------------------
>
>                 Key: HDFS-1969
>                 URL: https://issues.apache.org/jira/browse/HDFS-1969
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Blocker
>             Fix For: 0.22.0
>
>         Attachments: hdfs-1969.txt
>
>
> The following sequence leaves the namespace in an inconsistent/broken state:
> - format NN using 0.20 (or any prior release, probably)
> - run hdfs namenode -upgrade on 0.22. ^C the NN once it comes up.
> - run hdfs namenode -rollback on 0.22  (this should fail but doesn't!)
> This leaves the name directory in a state such that the version file claims 
> it's an 0.20 namespace, but the fsimage is in 0.22 format. It then crashes 
> when trying to start up.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to