[
https://issues.apache.org/jira/browse/HDFS-12026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16078957#comment-16078957
]
Allen Wittenauer commented on HDFS-12026:
-----------------------------------------
Hi gang.
Some outside observation: this patch is a bit problematic right now.
Both gcc and clang are now both required for building the native components.
Outside of testing, that's extreme overkill. There's no reason for a normal
build to do that.
Hard-coding the locations of things outside of the source tree needs to be done
with extreme care. In this particular case, there's no guarantee on any given
platform that, e.g., /usr/bin/gcc actually exists or is even the compiler in
use. To make it even more exciting, systems like OS X actually ship clang as
/usr/bin/gcc, which makes this test even more... interesting.
If you want to do these extra steps ONLY during CI, then you can wrap them in
the "test-patch" maven profile. mvn -Ptest-patch is used on every single
command line when Apache Yetus is used to invoke the build.
As a side note, it should probably be pointed out that this branch is *way* far
behind trunk right now. Some effort should probably be spent in getting it up
to speed, especially given that I'd hope this feature would appear in 3.0.0
beta1.
> libhdfs++: Fix compilation errors and warnings when compiling with Clang
> -------------------------------------------------------------------------
>
> Key: HDFS-12026
> URL: https://issues.apache.org/jira/browse/HDFS-12026
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: Anatoli Shein
> Assignee: Anatoli Shein
> Attachments: HDFS-12026.HDFS-8707.000.patch,
> HDFS-12026.HDFS-8707.001.patch, HDFS-12026.HDFS-8707.002.patch,
> HDFS-12026.HDFS-8707.003.patch, HDFS-12026.HDFS-8707.004.patch,
> HDFS-12026.HDFS-8707.005.patch, HDFS-12026.HDFS-8707.006.patch
>
>
> Currently multiple errors and warnings prevent libhdfspp from being compiled
> with clang. It should compile cleanly using flags:
> -std=c++11 -stdlib=libc++
> and also warning flags:
> -Weverything -Wno-c++98-compat -Wno-missing-prototypes
> -Wno-c++98-compat-pedantic -Wno-padded -Wno-covered-switch-default
> -Wno-missing-noreturn -Wno-unknown-pragmas -Wconversion -Werror
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
