[
https://issues.apache.org/jira/browse/HDFS-12026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16080981#comment-16080981
]
Allen Wittenauer commented on HDFS-12026:
-----------------------------------------
OK, it sounds like we're all on the same page. :)
I think adding clang to the Dockerfile is fine. I'm not sure which compiler
cmake picks up by default, but we can add a maven test-patch profile stanza to
test the "other" compiler during CI. That's all more than reasonable and I'm
really happy you folks are thinking about it. I'm just more concerned about
the burden this may put on non-CI stuff. :)
Doing a quick search, it looks like there is only one left:
hadoop-project/pom.xml if you need an example. That profile setting turns on
java linting, FWIW.
> libhdfs++: Fix compilation errors and warnings when compiling with Clang
> -------------------------------------------------------------------------
>
> Key: HDFS-12026
> URL: https://issues.apache.org/jira/browse/HDFS-12026
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: Anatoli Shein
> Assignee: Anatoli Shein
> Attachments: HDFS-12026.HDFS-8707.000.patch,
> HDFS-12026.HDFS-8707.001.patch, HDFS-12026.HDFS-8707.002.patch,
> HDFS-12026.HDFS-8707.003.patch, HDFS-12026.HDFS-8707.004.patch,
> HDFS-12026.HDFS-8707.005.patch, HDFS-12026.HDFS-8707.006.patch
>
>
> Currently multiple errors and warnings prevent libhdfspp from being compiled
> with clang. It should compile cleanly using flags:
> -std=c++11 -stdlib=libc++
> and also warning flags:
> -Weverything -Wno-c++98-compat -Wno-missing-prototypes
> -Wno-c++98-compat-pedantic -Wno-padded -Wno-covered-switch-default
> -Wno-missing-noreturn -Wno-unknown-pragmas -Wconversion -Werror
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
