[
https://issues.apache.org/jira/browse/HDFS-12118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16082130#comment-16082130
]
Yiqun Lin commented on HDFS-12118:
----------------------------------
Attach the initial patch.
Found one bug when I worked on this. The command {{-updateVolume -user/owner}}
doesn't work. In class {{UpdateVolumeHandler}}, it uses {{-owner}} to parse
arguments while this option didn't defined in {{Shell#addVolumeCommands}}.And
this will lead a failure.
Here I'm so sure if we should use {{-owner}} or {{-user}} to update the owner
of the specified volume. From the design doc, it also didn't mentions. In the
current patch, I'd like to use {{-user}} since the listVolumes has already used
to specified the owner of volumes. Also add some error test conditions to help
us check if the response content is we expected.
> Ozone: Ozone shell: Add more testing for volume shell commands
> --------------------------------------------------------------
>
> Key: HDFS-12118
> URL: https://issues.apache.org/jira/browse/HDFS-12118
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone, tools
> Affects Versions: HDFS-7240
> Reporter: Yiqun Lin
> Assignee: Yiqun Lin
> Attachments: HDFS-12118-HDFS-7240.001.patch
>
>
> Currently there are missing enough testing to cover all the ozone command.
> Now we have to test this in a manual way to see if commands run okay as
> expected. There will be lots of test cases we should add for all the volume,
> bucket and key commands. In order to easy reviewed, I'd like to separate this
> work to three subtasks. This JIRA is a good start for implementing for volume
> commands.
> Plan to add the unit test to test following command and its available options:
> * infoVolume
> * updateVolume
> * listVolume
> * createVolume
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
