[
https://issues.apache.org/jira/browse/HDFS-12118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16082712#comment-16082712
]
Chen Liang commented on HDFS-12118:
-----------------------------------
Thanks [~linyiqun] for working on this! We do need a lot more unit tests just
like these. v001 patch LGTM overall. With some minor comments,
1. {{testListVolumes}} has checks such as {{assertEquals(2, volumes.size());}}.
Is it possible that, in addition to checking the size of the list, also
checking that the elements in the {{volumes}} list is indeed what we expect,
e.g. the name and the user of the returned volumes match what we expect?
2. Also, since system output and error streams seem to be redirected, it might
be better to restore the system streams somewhere after the tests (e.g. in the
@After method). In case some future tests added to this class need to use
original, un-redirected system streams.
Additionally, I think it would be great if we follow up with other JIRAs for
adding more tests for bucket and key commands to this class.
> Ozone: Ozone shell: Add more testing for volume shell commands
> --------------------------------------------------------------
>
> Key: HDFS-12118
> URL: https://issues.apache.org/jira/browse/HDFS-12118
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone, tools
> Affects Versions: HDFS-7240
> Reporter: Yiqun Lin
> Assignee: Yiqun Lin
> Attachments: HDFS-12118-HDFS-7240.001.patch
>
>
> Currently there are missing enough testings to cover all the ozone command.
> Now we have to test this in a manual way to see if commands run okay as
> expected. There will be lots of test cases we should add for all the volume,
> bucket and key commands. In order to easy reviewed, I'd like to separate this
> work to three subtasks. This JIRA is a good start for implementing for volume
> commands.
> Plan to add the unit test to test following command and its available options:
> * infoVolume
> * updateVolume
> * listVolume
> * createVolume
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
