[
https://issues.apache.org/jira/browse/HDFS-12123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087804#comment-16087804
]
Anu Engineer commented on HDFS-12123:
-------------------------------------
*OzoneClientImpl.java*
* Line: 100, Please add a Preconditions.checkNotNull(conf);
* Line 229, Please add Preconditions.checkState(quota >= 0);
* Line 273, 281.. , Compiler warns that null is Confusing, plese rw-write as
(OzoneAcl) null.
* Line 317, no change is needed, just a comment. We don't have a good user
model yet, neither ACLs model. At some point you might want to define it in
detail. Let us get this code in for now.
* Line 435, // TODO: the following createContainer and key writes may fail, in
which
// case we should revert the above allocateKey to KSM.
I think this a JIRA that we should file against KSM. Clients might fail
before they can do this. So it is really KSM which needs to keep track of this
and
cleanup. I know I wrote this comment long time ago. So taking this
opportunity to fix my mistake.
* Line 442, Nit: That line can be in a single line.
* Line 445, Nit: 81 chars ??
I don't like that fact that we cannot assert in *TestOzoneClientImpl*, but I
understand why. I hope your next patch will enable full scale testing.
I am +1 with these minor nits addressed.
> Ozone: OzoneClient: Abstraction of OzoneClient and default implementation
> -------------------------------------------------------------------------
>
> Key: HDFS-12123
> URL: https://issues.apache.org/jira/browse/HDFS-12123
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Reporter: Nandakumar
> Assignee: Nandakumar
> Attachments: HDFS-12123-HDFS-7240.000.patch
>
>
> {{OzoneClient}} interface defines all the client operations supported by
> Ozone.
> {{OzoneClientImpl}} will have the default implementation, it should connects
> to KSM, SCM and DataNode through RPC protocol to execute client calls.
> Similarly we should have a client implementation which implements
> {{OzoneClient}} and uses REST protocol to execute client calls.
> This will provide lots of flexibility to Ozone applications, when
> applications are running inside the cluster, they can use RPC protocol, but
> when running from outside the cluster, the same applications can speak REST
> protocol to communicate with Ozone.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
