[
https://issues.apache.org/jira/browse/HDFS-12123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087992#comment-16087992
]
Nandakumar commented on HDFS-12123:
-----------------------------------
Thanks [~anu] for the review.
>> Line: 100, Please add a Preconditions.checkNotNull(conf);
Added
>> Line 229, Please add Preconditions.checkState(quota >= 0);
Added
>> Line 273, 281.. , Compiler warns that null is Confusing, plese rw-write as
>> (OzoneAcl) null.
Done
>> Line 442, Nit: That line can be in a single line.
Done
>> Line 445, Nit: 81 chars ??
Corrected
>> I think this a JIRA that we should file against KSM.
I will create a JIRA to track the same
Uploaded patch v1 incorporating review comments.
> Ozone: OzoneClient: Abstraction of OzoneClient and default implementation
> -------------------------------------------------------------------------
>
> Key: HDFS-12123
> URL: https://issues.apache.org/jira/browse/HDFS-12123
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Reporter: Nandakumar
> Assignee: Nandakumar
> Attachments: HDFS-12123-HDFS-7240.000.patch,
> HDFS-12123-HDFS-7240.001.patch
>
>
> {{OzoneClient}} interface defines all the client operations supported by
> Ozone.
> {{OzoneClientImpl}} will have the default implementation, it should connects
> to KSM, SCM and DataNode through RPC protocol to execute client calls.
> Similarly we should have a client implementation which implements
> {{OzoneClient}} and uses REST protocol to execute client calls.
> This will provide lots of flexibility to Ozone applications, when
> applications are running inside the cluster, they can use RPC protocol, but
> when running from outside the cluster, the same applications can speak REST
> protocol to communicate with Ozone.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
