[
https://issues.apache.org/jira/browse/HDFS-12159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16093957#comment-16093957
]
Xiaoyu Yao commented on HDFS-12159:
-----------------------------------
Patch looks good to me overall. Just few minor issues:
Ozone.proto
Line 76: should we add CHAINED replication pipeline as place holder?
StorageContainerLocationProtocol.proto
Do we have other management APIs to be added later, e.g., list/delete/get
Pipleline?
StorageContainerLocationProtocolServerSideTranslatorPB.java
Line 164: TODO?
PipelineManager.java
Line 32: NIT: should we call this like createPipeline?
Line 38: can you elaborate on the implication of closeCluster()? Does it
delete/remove the pipeline?
> Ozone: SCM: Add create replication pipeline RPC
> -----------------------------------------------
>
> Key: HDFS-12159
> URL: https://issues.apache.org/jira/browse/HDFS-12159
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Anu Engineer
> Assignee: Anu Engineer
> Fix For: HDFS-7240
>
> Attachments: HDFS-12159-HDFS-7240.001.patch
>
>
> Add an API that allows users to create replication pipelines using SCM.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
