[ 
https://issues.apache.org/jira/browse/HDFS-12159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109621#comment-16109621
 ] 

Xiaoyu Yao commented on HDFS-12159:
-----------------------------------

Thanks [~anu] for updating the patch. Patch v2 looks good to me. Just have two 
NITs:

PipelineManager.java
Line 26: NIT: should be Ozone pipelines.

MiniOzoneCluster.java
Line 81/105: Should we change this to allow different replication types so that 
we can have test coverage on both Ratis and other replication types? 




> Ozone: SCM: Add create replication pipeline RPC
> -----------------------------------------------
>
>                 Key: HDFS-12159
>                 URL: https://issues.apache.org/jira/browse/HDFS-12159
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Anu Engineer
>            Assignee: Anu Engineer
>             Fix For: HDFS-7240
>
>         Attachments: HDFS-12159-HDFS-7240.001.patch, 
> HDFS-12159-HDFS-7240.002.patch
>
>
> Add an API that allows users to create replication pipelines using SCM.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to