[
https://issues.apache.org/jira/browse/HDFS-10874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16094830#comment-16094830
]
James Clampffer commented on HDFS-10874:
----------------------------------------
Note: I updated tests to use the new API and added a few bonus tests for URI
methods that didn't have coverage. Filed HDFS-12168 to get the test validation
stuff working with the C++ code.
[~mdeepak] Just to make sure I understand is your idea to catch whatever
exeptions thrown out of the parser that can be recovered right at the call
site? This is a really good idea that I'd forgotten about. I also think I
lied about the uri lib throwing, it's the XML parse that really likes to throw.
I filed HDFS-12169 to just make one pass at catching third-party exceptions
and getting things in better shape in terms of RAII. Would you be ok with
pushing the improvements you descried into that jira? Not that you have to do
the work, just in terms of a separate task to track it. When possible I like
to keep patches focused on a single goal just so it's easier to backport onto
other projects that have already shipped.
> libhdfs++: Public API headers should not depend on internal implementation
> --------------------------------------------------------------------------
>
> Key: HDFS-10874
> URL: https://issues.apache.org/jira/browse/HDFS-10874
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: James Clampffer
> Assignee: James Clampffer
> Attachments: HDFS-10874.HDFS-8707.000.patch,
> HDFS-10874.HDFS-8707.001.patch, HDFS-10874.HDFS-8707.002.patch
>
>
> Public headers need to do some combination of the following: stop including
> parts of the implementation, forward declare bits of the implementation where
> absolutely needed, or pull the implementation into include/hdfspp if it's
> inseparable.
> Example:
> If you want to use the C++ API and only stick include/hdfspp in the include
> path you'll get an error when you include include/hdfspp/options.h because
> that goes and includes common/uri.h.
> Related to the work described in HDFS-10787.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
