[
https://issues.apache.org/jira/browse/HDFS-10874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16094909#comment-16094909
]
James Clampffer commented on HDFS-10874:
----------------------------------------
Thanks for the reviews [[email protected]] and [~mdeepak]! I'll let this sit
out for the rest of the day before committing in case anyone else has feedback.
> libhdfs++: Public API headers should not depend on internal implementation
> --------------------------------------------------------------------------
>
> Key: HDFS-10874
> URL: https://issues.apache.org/jira/browse/HDFS-10874
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: James Clampffer
> Assignee: James Clampffer
> Attachments: HDFS-10874.HDFS-8707.000.patch,
> HDFS-10874.HDFS-8707.001.patch, HDFS-10874.HDFS-8707.002.patch
>
>
> Public headers need to do some combination of the following: stop including
> parts of the implementation, forward declare bits of the implementation where
> absolutely needed, or pull the implementation into include/hdfspp if it's
> inseparable.
> Example:
> If you want to use the C++ API and only stick include/hdfspp in the include
> path you'll get an error when you include include/hdfspp/options.h because
> that goes and includes common/uri.h.
> Related to the work described in HDFS-10787.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
