[
https://issues.apache.org/jira/browse/HDFS-12178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16098930#comment-16098930
]
Chen Liang commented on HDFS-12178:
-----------------------------------
Thanks [~nandakumar131] for the patch! Nice catch on the multi-threading case.
Curious though, is there a case where multiple threads will try to create the
same container?
And for these two lines:
{code}
containersCreated.add(containerName);
ContainerProtocolCalls.createContainer(xceiverClient, requestId);
{code}
{{createContainer}} can fail, but it already gets added to containersCreated
set to this point. So how about switch the order of the two calls, or simply
move {{containersCreated.add()}} to after the try-catch?
> Ozone: OzoneClient: Handling SCM container creationFlag at client side
> ----------------------------------------------------------------------
>
> Key: HDFS-12178
> URL: https://issues.apache.org/jira/browse/HDFS-12178
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Reporter: Nandakumar
> Assignee: Nandakumar
> Attachments: HDFS-12178-HDFS-7240.000.patch,
> HDFS-12178-HDFS-7240.001.patch
>
>
> SCM BlockManager provisions a pool of containers upon block creation request,
> only one container is returned with creationFlag to the client. The other
> containers provisioned in the same batch will not have this flag. This jira
> is to handle that scenario at client side, until HDFS-11888 is fixed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
