[ 
https://issues.apache.org/jira/browse/HDFS-12178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16103876#comment-16103876
 ] 

Chen Liang commented on HDFS-12178:
-----------------------------------

Thanks [~nandakumar131] for the elaboration and updating the patch, checking 
{{CONTAINER_EXISTS}} LGTM, can we move 
{{containersCreated.add(containerName);}} to after the try-catch clause such 
that we don't need to call it two places? Also, for {{containersCreated}}, 
seems order of the container name doesn't matter, only their presence, so would 
be it better to change {{ArrayList}} to {{HashSet}} for the O(1) 
{{contains(...)}}?

> Ozone: OzoneClient: Handling SCM container creationFlag at client side
> ----------------------------------------------------------------------
>
>                 Key: HDFS-12178
>                 URL: https://issues.apache.org/jira/browse/HDFS-12178
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>            Reporter: Nandakumar
>            Assignee: Nandakumar
>         Attachments: HDFS-12178-HDFS-7240.000.patch, 
> HDFS-12178-HDFS-7240.001.patch, HDFS-12178-HDFS-7240.002.patch
>
>
> SCM BlockManager provisions a pool of containers upon block creation request, 
> only one container is returned with creationFlag to the client. The other 
> containers provisioned in the same batch will not have this flag. This jira 
> is to handle that scenario at client side, until  HDFS-11888 is fixed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to