[
https://issues.apache.org/jira/browse/HDFS-12196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108607#comment-16108607
]
Weiwei Yang commented on HDFS-12196:
------------------------------------
[~vagarychen]
thanks for the review.
bq. Can we somehow add the priority enforcement to the abstractions also?
It makes sense, I have added a {{BackgroundTaskQueue}} for better encapsulation.
bq. I was wondering will there be anyone that will be reading RecyclingResult?
I suppose so. It is not required now, but good to have. For example with cached
result, DN could answer back SCM deleted block list without querying its
database. And as now it becomes to be a more general interface, it might be
useful in other scenarios.
bq. Also I felt the term "recycling" here is not that informative, because it
does not seem that we recycling anything, but can't think of a better
alternative...
the name of "recycling" implies the service is trying to delete staled stuff
and recycle space for ozone. But just let me know if you have any better idea
about the naming.
[~anu]
Thanks for your review. I have created {{BackgroundService}},
{{BackgroundTask}}, do you think this is general enough for ozone background
services? Please take a look at v2 patch.
Thank you.
> Ozone: DeleteKey-2: Implement container recycling service to delete stale
> blocks at background
> ----------------------------------------------------------------------------------------------
>
> Key: HDFS-12196
> URL: https://issues.apache.org/jira/browse/HDFS-12196
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Reporter: Weiwei Yang
> Assignee: Weiwei Yang
> Attachments: HDFS-12196-HDFS-7240.001.patch,
> HDFS-12196-HDFS-7240.002.patch
>
>
> Implement a recycling service running on datanode to delete stale blocks.
> The recycling service scans staled blocks for each container and delete
> chunks and references periodically.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
