[ 
https://issues.apache.org/jira/browse/HDFS-12036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116079#comment-16116079
 ] 

Kai Zheng commented on HDFS-12036:
----------------------------------

Hi [~HuafengWang],

This looks close. Two minors by the way:
1. {{FSNamesystem->addECPolicies}} might be {{addErasureCodingPolicies}} to be 
consistent.
2. Your way to put the {{logAuditEvent}} statement in the {{finally}} block is 
better, would you refine other places in the same way? 

Thanks!

> Add audit log for getErasureCodingPolicy, getErasureCodingPolicies, 
> getErasureCodingCodecs
> ------------------------------------------------------------------------------------------
>
>                 Key: HDFS-12036
>                 URL: https://issues.apache.org/jira/browse/HDFS-12036
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>    Affects Versions: 3.0.0-alpha4
>            Reporter: Wei-Chiu Chuang
>            Assignee: Huafeng Wang
>              Labels: hdfs-ec-3.0-must-do
>         Attachments: HDFS-12036.001.patch, HDFS-12036.002.patch
>
>
> These three FSNameSystem operations do not yet record audit logs. I am not 
> sure how useful these audit logs would be, but thought I should file them so 
> that they don't get dropped if they turn out to be needed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to