[
https://issues.apache.org/jira/browse/HDFS-12036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116327#comment-16116327
]
Kai Zheng commented on HDFS-12036:
----------------------------------
Thanks [~HuafengWang] for the update!
Just noticed another minor in existing codes. Could you fix it by the way?
Thanks!
{code}
* Get available erasure coding codecs and corresponding coders.
*/
HashMap<String, String> getErasureCodingCodecs() throws IOException {
+ final String operationName = "getErasureCodingCodecs";
+ boolean success = false;
checkOperation(OperationCategory.READ);
readLock();
try {
checkOperation(OperationCategory.READ);
- return FSDirErasureCodingOp.getErasureCodingCodecs(this);
+ final HashMap<String, String> ret =
+ FSDirErasureCodingOp.getErasureCodingCodecs(this);
+ success = true;
{code}
The function would be better to return a Map instead of a HashMap. And also to
{{FSDirErasureCodingOp.getErasureCodingCodecs}}
> Add audit log for getErasureCodingPolicy, getErasureCodingPolicies,
> getErasureCodingCodecs
> ------------------------------------------------------------------------------------------
>
> Key: HDFS-12036
> URL: https://issues.apache.org/jira/browse/HDFS-12036
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Affects Versions: 3.0.0-alpha4
> Reporter: Wei-Chiu Chuang
> Assignee: Huafeng Wang
> Labels: hdfs-ec-3.0-must-do
> Attachments: HDFS-12036.001.patch, HDFS-12036.002.patch,
> HDFS-12036.003.patch
>
>
> These three FSNameSystem operations do not yet record audit logs. I am not
> sure how useful these audit logs would be, but thought I should file them so
> that they don't get dropped if they turn out to be needed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
