[ 
https://issues.apache.org/jira/browse/HDFS-12327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135387#comment-16135387
 ] 

Weiwei Yang commented on HDFS-12327:
------------------------------------

Hi [~linyiqun]

Thanks for working on this, it looks almost good to me. Just one thought, maybe 
we should enable the timeout by default for {{BlockDeletingService}}. We have 
{{ozone.block.deleting.limit.per.task}} to throttle number of blocks to delete 
per task, I think we can set a default value to {{300000ms}}, 5min should be 
enough for deleting 1000 blocks I suppose. And please add a doc in 
ozone-default.xml, this value should be increased with 
{{ozone.block.deleting.limit.per.task}}. Another nit is can we use {{int}} for 
the timeout instead of long?

Thanks

> Ozone: support setting timeout in background service
> ----------------------------------------------------
>
>                 Key: HDFS-12327
>                 URL: https://issues.apache.org/jira/browse/HDFS-12327
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Yiqun Lin
>            Assignee: Yiqun Lin
>         Attachments: HDFS-12327-HDFS-7240.001.patch, 
> HDFS-12327-HDFS-7240.002.patch
>
>
> The background should support timeout setting in case the task ran hung 
> caused by unpredictability sceneries.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to