[
https://issues.apache.org/jira/browse/HDFS-12327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136399#comment-16136399
]
Yiqun Lin commented on HDFS-12327:
----------------------------------
Thanks for the review, [~cheersynang]. All the comments make sense to me except
this one.
bq. Another nit is can we use int for the timeout instead of long?
We don't need to change the type of timeout I think. Method
{{Configuration#getTimeDuration}} returns the {{long}} type value. If we use
{{int}} type for the timeout, that means we will cast long to int of timeout
value each time in subclass of background service. There is also a risk of
losing precision that we do the type cast operation.
Attach the updated patch.
> Ozone: support setting timeout in background service
> ----------------------------------------------------
>
> Key: HDFS-12327
> URL: https://issues.apache.org/jira/browse/HDFS-12327
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Yiqun Lin
> Assignee: Yiqun Lin
> Attachments: HDFS-12327-HDFS-7240.001.patch,
> HDFS-12327-HDFS-7240.002.patch
>
>
> The background should support timeout setting in case the task ran hung
> caused by unpredictability sceneries.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
