[ 
https://issues.apache.org/jira/browse/HDFS-12377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16149988#comment-16149988
 ] 

Xiao Chen commented on HDFS-12377:
----------------------------------

Thanks Andrew for taking care of pre-commits here! Looks pretty good to me.

Looking at the failure, 
{{TestReadStripedFileWithDecoding#testReadWithDNFailure}} also needs 
parameterizing.
Also, do you have insights about what's changed recently? IIRC pre-commit was 
fairly green at least a week ago. 

> Refactor TestReadStripedFileWithDecoding to avoid test timeouts
> ---------------------------------------------------------------
>
>                 Key: HDFS-12377
>                 URL: https://issues.apache.org/jira/browse/HDFS-12377
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: erasure-coding
>    Affects Versions: 3.0.0-alpha3
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>         Attachments: HDFS-12377.001.patch, HDFS-12377.002.patch
>
>
> This test times out since the nested for loops means it runs 12 
> configurations inside each test method.
> Let's refactor this to use JUnit parameters instead.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to