[ 
https://issues.apache.org/jira/browse/HDFS-12377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16152055#comment-16152055
 ] 

Xiao Chen commented on HDFS-12377:
----------------------------------

Thanks for revving Andrew! +1 pending:
- {{TestReadStripedFileWithDNFailure}} runs in the same time range as the other 
2 classes (~25s on my local). I think it makes sense to raise the test case's 
timeout there to 5 min too, instead of the current class-level 2 min.
- checkstyle

Agree on improving EC tests' stability. LMK if I can help.
It also feels to me the tests are more flaky these days not specific to EC, not 
sure if anything env-related changed? (or how we could find out)

> Refactor TestReadStripedFileWithDecoding to avoid test timeouts
> ---------------------------------------------------------------
>
>                 Key: HDFS-12377
>                 URL: https://issues.apache.org/jira/browse/HDFS-12377
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: erasure-coding
>    Affects Versions: 3.0.0-alpha3
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>         Attachments: HDFS-12377.001.patch, HDFS-12377.002.patch, 
> HDFS-12377.003.patch
>
>
> This test times out since the nested for loops means it runs 12 
> configurations inside each test method.
> Let's refactor this to use JUnit parameters instead.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to