[
https://issues.apache.org/jira/browse/HDFS-12395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16161095#comment-16161095
]
Rakesh R commented on HDFS-12395:
---------------------------------
Thanks [~Sammi] for the continuous efforts.
bq. I'm not very sure about the "Update javadocs" comments, is that because
new parameter "logRetryCache" is added for involved API?
Yes, good to could update javadoc,
(1) with new param.
{code}
* @param logRetryCache whether to record RPC ids in editlog for retry cache
* rebuilding
{code}
(2) Secondly, since you are touching {{FSDirErasureCodingOp}} functions, could
you please add javadoc for the APIs which doesn't have details presently.
{code}
FSDirErasureCodingOp#addErasureCodingPolicy,
FSDirErasureCodingOp#removeErasureCodingPolicy,
FSDirErasureCodingOp#enableErasureCodingPolicy,
FSDirErasureCodingOp#disableErasureCodingPolicy functions.
{code}
> Support erasure coding policy operations in namenode edit log
> -------------------------------------------------------------
>
> Key: HDFS-12395
> URL: https://issues.apache.org/jira/browse/HDFS-12395
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: erasure-coding
> Reporter: SammiChen
> Assignee: SammiChen
> Labels: hdfs-ec-3.0-must-do
> Attachments: editsStored, HDFS-12395.001.patch, HDFS-12395.002.patch
>
>
> Support add, remove, disable, enable erasure coding policy operation in edit
> log.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
