[
https://issues.apache.org/jira/browse/HDFS-12395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16164482#comment-16164482
]
SammiChen commented on HDFS-12395:
----------------------------------
Thanks [~drankye] & [~rakeshr] reviewing the patch!
Following comments will be added later as the follow-ons. All other comments
are addressed in the 003.patch
{quote}
3. You changes in DFSClient looks like some bug fix to existing codes.
4. Refactor: getEcPolicy => getErasureCodingPolicy; AddECPolicyResponse =>
AddErasureCodingPolicyResponse
5. Don't quite like the way to sort the map by creating a tree map. And also,
could we improve ECSchema to ensure extraOptions is sorted already, so we don't
need to consider doing it in every places? If you'd do this, please in separate
issue.
{quote}
> Support erasure coding policy operations in namenode edit log
> -------------------------------------------------------------
>
> Key: HDFS-12395
> URL: https://issues.apache.org/jira/browse/HDFS-12395
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: erasure-coding
> Reporter: SammiChen
> Assignee: SammiChen
> Labels: hdfs-ec-3.0-must-do
> Attachments: editsStored, HDFS-12395.001.patch, HDFS-12395.002.patch,
> HDFS-12395.003.patch
>
>
> Support add, remove, disable, enable erasure coding policy operation in edit
> log.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
