[ 
https://issues.apache.org/jira/browse/HDFS-12420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167013#comment-16167013
 ] 

Arpit Agarwal commented on HDFS-12420:
--------------------------------------

Thanks [~ajayydv]. I liked the idea of disallowing format completely but this 
approach should address Vinay and Allen's concerns.

Few comments on the patch:
# The following can be replaced with conf.getBoolean
{code}
conf.get(DFSConfigKeys.DFS_CLUSTER_IS_PROD, DFSConfigKeys
          .DFS_CLUSTER_IS_PROD_DEFAULT).equalsIgnoreCase("true")
{code}
# We should set {{force}} and {{isInteractive}} to false if its a prod cluster 
to remove any possibility of deleting data. Also you can log a warning saying 
_... prod cluster. Ignoring the --force and --nonInteractive flags._
# Move the new property to core-site/CommonConfigurationKeysPublic. Also you 
could consider renaming it to something like {{hadoop.is.prod.cluster}}.

> Disable Namenode format for prod clusters when data already exists
> ------------------------------------------------------------------
>
>                 Key: HDFS-12420
>                 URL: https://issues.apache.org/jira/browse/HDFS-12420
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Ajay Kumar
>            Assignee: Ajay Kumar
>         Attachments: HDFS-12420.01.patch, HDFS-12420.02.patch, 
> HDFS-12420.03.patch, HDFS-12420.04.patch
>
>
> Disable NameNode format to avoid accidental formatting of Namenode in 
> production cluster. If someone really wants to delete the complete fsImage, 
> they can first delete the metadata dir and then run {code} hdfs namenode 
> -format{code} manually.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to