[
https://issues.apache.org/jira/browse/HDFS-12420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167148#comment-16167148
]
Rushabh S Shah commented on HDFS-12420:
---------------------------------------
Couple of minor comments from me.
1.
bq. + public static final String HADOOP_CLUSTER_IS_PROD =
"hadoop.is.prod.cluster";
This is just a namenode side config. We should prefix it as
{{dfs.namenode.is.prod.cluster}}.
The equivalent member variable name should be {{DFS_NAMENODE_IS_PROD_CLUSTER}}.
2.
The config key should de defined in
{{hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java}}
and not {{CommonConfigurationKeys.java}}
Also the default value should be defined in {{hdfs-default.xml}} instead of
{{core-default.xml}}
Other than that the patch looks good to me.
> Disable Namenode format for prod clusters when data already exists
> ------------------------------------------------------------------
>
> Key: HDFS-12420
> URL: https://issues.apache.org/jira/browse/HDFS-12420
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Ajay Kumar
> Assignee: Ajay Kumar
> Attachments: HDFS-12420.01.patch, HDFS-12420.02.patch,
> HDFS-12420.03.patch, HDFS-12420.04.patch, HDFS-12420.05.patch
>
>
> Disable NameNode format to avoid accidental formatting of Namenode in
> production cluster. If someone really wants to delete the complete fsImage,
> they can first delete the metadata dir and then run {code} hdfs namenode
> -format{code} manually.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
